Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BSK bump: macOS geoswitching nearest city bug-fix #2706

Closed
wants to merge 2 commits into from
Closed

BSK bump: macOS geoswitching nearest city bug-fix #2706

wants to merge 2 commits into from

Conversation

graeme
Copy link
Contributor

@graeme graeme commented Apr 10, 2024

Task/Issue URL: https://app.asana.com/0/1203137811378537/1207044169885477/f

Description:
Just the BSK bump for a macOS fix. See duckduckgo/macos-browser#2589 for details.

Steps to test this PR:

  1. Make sure you’re hitting the production VPN environment (so you get the full countries + cities).
  2. Go to VPN Location screen
  3. Go to a country with multiple cities (currently only the US) and select any specific city
  4. Now select Nearest (explicitly using the drop-down)
  5. Go to the VPN management popover (e.g nav bar → … → VPN) and connect

Expected
VPN connects to the nearest city in that country

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

@github-actions GitHub Actions
Copy link

🚫 The Asana task linked in the PR description is not added to iOS App Board project.

  1. Verify that the correct task is linked in the PR.
    • ⚠️ Please use the actual implementation task, rather than the Code Review subtask.
  2. Verify that the task is added to iOS App Board project.
  3. When ready, remove the bot: not in app board label to retrigger the check.

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Apr 10, 2024
@graeme graeme mentioned this pull request Apr 10, 2024
Merged
6 tasks
@graeme graeme changed the title BSK bump for macOS geoswitching bug-fix BSK bump: macOS geoswitching nearest city bug-fix Apr 10, 2024
diegoreymendez
diegoreymendez requested changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@diegoreymendez diegoreymendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not approving this since as you mentioned on a call @graeme , this is not necessary anymore.

Let me know if that changes and I'll test.

@graeme graeme closed this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegoreymendez diegoreymendez diegoreymendez requested changes

Assignees
No one assigned
Labels
bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graeme @diegoreymendez